[CIS-1167] Implement token refreshing for HTTP requests #1446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbarbugli
reviewed
Sep 13, 2021
dmigach
force-pushed
the
CIS-1167-token-exiration
branch
from
9c926de
to
3b5ac4e
Compare
nuno-vieira
previously approved these changes
Sep 17, 2021
| @Atomic private var tokenRefreshConsecutiveFailures: Int = 0 | ||
|
|
||
| /// How many times can the token refresh fail before giving up with an error | ||
| let maxTokenRefreshAttempts = 10 |
There was a problem hiding this comment.
Isn't this too much? 🤔 AFAIK on iOS the default for this kind of thing is 5.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we only refresh expired token when we get an error over WebSocket connection which is suboptimal because backend doesn't send an event for token expiration. So we should react to this error when we get it as a response for an HTTP request
There are three main things to consider, all covered with a corresponding test:
When request fail, we add them to a queue to retry them later with a new token.
Then we try refreshing the token, if it's successful - retry all the failed requests
If refreshing failed or hanging - timeout all the requests with failures
Two main cases to test: