Fixing constraint issues by changing BottomContainer to be a standard UIStackView instead of custom one #1545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 13, 2021 10:50
… UIStackView instead of custom one
Codecov Report
@@ Coverage Diff @@
## main #1545 +/- ##
=======================================
Coverage 87.82% 87.82%
=======================================
Files 232 232
Lines 10971 10971
=======================================
Hits 9635 9635
Misses 1336 1336
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
nuno-vieira
reviewed
Oct 14, 2021
tbarbugli
approved these changes
Oct 15, 2021
nuno-vieira
pushed a commit
that referenced
this pull request
Oct 21, 2021
… UIStackView instead of custom one (#1545)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
We are currently getting a broken constraint on the
ComposerViewon a simple integration. This issue exists in our customerContainerStackViewwhereby we have built our customStackViewimplementation.🛠 Implementation
We have made the
BottomContainera standardUIStackViewthis is a small change because the API matches our custom version and will still allow integrations to override this stack view but more stable as it's provided and supported by the OS.🧪 Testing
I have tested this on our DemoApp but I am also going to reach out to various customers to make sure this still works as expected. But I have tested across multiples devices (iPhone/iPad) and also Portrait/Landscape.
☑️ Checklist