Fix Whitespace Appearing on Gallery View #1563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nuno-vieira
previously approved these changes
Oct 19, 2021
* Fix `ChatMessagePopupVC` tests * Bump xcode version to `12.5.1` on CI
Codecov Report
@@ Coverage Diff @@
## main #1563 +/- ##
==========================================
+ Coverage 87.80% 87.95% +0.15%
==========================================
Files 232 232
Lines 10970 11029 +59
==========================================
+ Hits 9632 9701 +69
+ Misses 1338 1328 -10
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
evsaev
reviewed
Oct 21, 2021
| @@ -14,7 +14,7 @@ concurrency: | |||
|
|
|||
| env: | |||
| HOMEBREW_NO_INSTALL_CLEANUP=1: 1 # Disable cleanup for homebrew, we don't need it on CI | |||
| DEVELOPER_DIR: /Applications/Xcode_12.5.app/Contents/Developer | |||
| DEVELOPER_DIR: /Applications/Xcode_12.5.1.app/Contents/Developer | |||
There was a problem hiding this comment.
hm, that is already on main, right? 🤔
evsaev
approved these changes
Oct 21, 2021
Yeah, I had to bring it in so that CI would work :] |
nuno-vieira
pushed a commit
that referenced
this pull request
Oct 21, 2021
* Adding the `finishInteractiveTransition` required to close up the animations * Updating CHANGELOG * [CIS-1242] Update CI to use `Xcode 12.5.1` (#1568) * Fix `ChatMessagePopupVC` tests * Bump xcode version to `12.5.1` on CI * Updating CHANGELOG * Removing duplicate entry in the CHANGELOG Co-authored-by: Adam Rush <adam.rush@getstream.io> Co-authored-by: Pavel Evsaev <pavel.evsaev@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Issue Link
https://stream-io.atlassian.net/browse/CIS-1229
🎯 Goal
We are fixing an issue reported via GitHub, which shows a whitespace when dismissing a Gallery View via Pan Gesture.
🛠 Implementation
We had to implement the
transitionFinishedfunction provided by Apple's framework. This closes up the transitions and therefore respecting the responder chain.🧪 Testing
Video
CorrectBehaviour.mov
☑️ Checklist