[CIS-1238] Remove AnyXXXXControllerDelegate Boilerplate Code
#1564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Generated by 🚫 Danger |
nuno-vieira
commented
Oct 19, 2021
Sources/StreamChat/Controllers/ChannelListController/ChannelListController+Combine.swift
Outdated
Show resolved
Hide resolved
nuno-vieira
changed the title
AnyXXXXControllerDelegate boilerplate codeAnyXXXXControllerDelegate Boilerplate Code
For some reason, without this the controller tests are not passing. Switching to `class` also make all tests failing still.
Codecov Report
@@ Coverage Diff @@
## main #1564 +/- ##
==========================================
- Coverage 87.87% 87.82% -0.05%
==========================================
Files 232 232
Lines 11029 10731 -298
==========================================
- Hits 9692 9425 -267
+ Misses 1337 1306 -31
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
tbarbugli
reviewed
Oct 20, 2021
evsaev
reviewed
Oct 21, 2021
Sources/StreamChat/Controllers/ChannelController/ChannelController.swift
Outdated
Show resolved
Hide resolved
b-onc
reviewed
Oct 21, 2021
Sources/StreamChat/Controllers/ChannelController/ChannelController.swift
Outdated
Show resolved
Hide resolved
Sources/StreamChat/Controllers/ChannelController/ChannelController.swift
Outdated
Show resolved
Hide resolved
evsaev
reviewed
Oct 21, 2021
Sources/StreamChat/Controllers/ConnectionController/ConnectionController.swift
Outdated
Show resolved
Hide resolved
evsaev
reviewed
Oct 21, 2021
b-onc
reviewed
Oct 21, 2021
Sources/StreamChat/Controllers/ChannelController/ChannelController.swift
Outdated
Show resolved
Hide resolved
b-onc
reviewed
Oct 21, 2021
b-onc
reviewed
Oct 21, 2021
Sources/StreamChat/Controllers/ChannelController/ChannelController_Tests.swift
Outdated
Show resolved
Hide resolved
Sources/StreamChat/Controllers/ChannelController/ChannelController.swift
Outdated
Show resolved
Hide resolved
b-onc
approved these changes
Oct 21, 2021
nuno-vieira
added a commit
that referenced
this pull request
Oct 21, 2021
* Refactor `MulticastDelegate` * Change all controllers to the new `MulticastDelegate` * Remove All `AnyXXXControllerDelegate` boilerplate code * New `MulticastDelegate` Tests * Remove unnecessary `mutating` keyword from `MulticastDelegate` * Add back support for the main Delegate in `MulticastDelegate` * Set all functions to mutating on `MulticastDelegate` For some reason, without this the controller tests are not passing. Switching to `class` also make all tests failing still. * Fix MessageDTO_Tests * Add tests to verify there are no retain cycles * Add replace API to `MulticastDelegate` to replace the additional delegates * Deprecate `setDelegate()` * Update CHANGELOG.md * Improve deprecated `setDelegate` implementation * Remove `removeAll()` API from `MulticastDelegate` * Change the `replace` API with `set(additionalDelegates:)` for consistency * Move all deprecations to Deprecations.swift file * Remove TestGenericDelegate leftover from ExtraData
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Issue Link
CIS-1238
🎯 Goal
Remove the
AnyXXXXControllerDelegateboilerplate code, which complicates a lot when adding or creating delegates for our controllers in the Low-Level SDK. Since we don't have the generic ExtraData anymore, this boilerplate code is not needed.🛠 Implementation
By refactoring the
MulticastDelegateand making sure the delegates are weakly referenced, we can totally discard theAnyXXXXControllerDelegateimplementations.🧪 Testing
A QA Run should be made to make sure nothing was broken.
@b-onc should also make sure the current implementation is correct, and it is compared with the old one. (I'm still not sure why we needed a "main" delegate before, but if this is necessary, we can put this back with the current implementation)Update: After discussing with Bahadir, I added back the mainDelegate toMulticastDelegate.🎨 Changes
N/A
☑️ Checklist