Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CIS-1242] Fix memory leak in GalleryVC #1631

Merged
merged 3 commits into from Nov 17, 2021

Conversation

nuno-vieira
Copy link
Member

@nuno-vieira nuno-vieira commented Nov 17, 2021

馃敆 Issue Link

CIS-1242
Possibly related to #1601 (Not sure)

馃幆 Goal

Fix memory leak of GalleryVC when opening the gallery preview. There was a memory leak caused by a forgotten weak ref of the transition context in the ZoomDismissalInteractionController.

馃洜 Implementation

Make ZoomDismissalInteractionController.transitionContext a weak ref.

馃И Testing

  1. Open a channel
  2. Open multiple times the gallery image preview
  3. Go back to the channel list
  4. Logout
  5. Open the Memory Graph
  6. Verify there are no GalleryVC instances in memory
    (If you do these steps on main, you can see multiple instances of GalleryVC)

馃帹 Changes

N/A

鈽戯笍 Checklist

  • I have signed the Stream CLA (required)
  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Affected documentation updated (docusaurus, tutorial, CMS (task created)

@nuno-vieira nuno-vieira added the 馃悶聽Bug An issue or PR related to a bug label Nov 17, 2021
@nuno-vieira nuno-vieira requested a review from a team November 17, 2021 22:00
@codecov
Copy link

codecov bot commented Nov 17, 2021

Codecov Report

Merging #1631 (fcb7468) into main (ff4f801) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1631   +/-   ##
=======================================
  Coverage   85.13%   85.13%           
=======================================
  Files         230      230           
  Lines       11048    11048           
=======================================
  Hits         9406     9406           
  Misses       1642     1642           
Flag Coverage 螖
llc-tests 85.13% <酶> (酶)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update ff4f801...fcb7468. Read the comment docs.

@nuno-vieira nuno-vieira merged commit 2f2138f into main Nov 17, 2021
@nuno-vieira nuno-vieira deleted the CIS-1342-Fix-memory-leak-galleryVC branch November 17, 2021 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
馃悶聽Bug An issue or PR related to a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants