[CIS-1273] Ensure optional Core Data attributes map to optional Swift types #1646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tbarbugli I looked into automatically comparing the model definitions in the core data model against the managed object definitions. I was unsuccessful. The one thing I kept running into is the lack of information on the managed objects at runtime. I have no way to request the nullability of properties defined on te class level. Getting the same info from Core Data is easy. |
Generated by 🚫 Danger |
Codecov Report
@@ Coverage Diff @@
## develop #1646 +/- ##
===========================================
- Coverage 85.24% 85.18% -0.06%
===========================================
Files 231 230 -1
Lines 11071 11066 -5
===========================================
- Hits 9437 9427 -10
- Misses 1634 1639 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
tbarbugli
reviewed
Nov 24, 2021
jeroenleenarts
force-pushed
the
CIS-1273-check-optionals
branch
2 times, most recently
from
bc29d67
to
3de57c3
Compare
bielikb
changed the title
jeroenleenarts
force-pushed
the
CIS-1273-check-optionals
branch
2 times, most recently
from
d065943
to
8222d9f
Compare
bielikb
reviewed
Dec 9, 2021
jeroenleenarts
force-pushed
the
CIS-1273-check-optionals
branch
from
8222d9f
to
38af61b
Compare
bielikb
previously approved these changes
Dec 10, 2021
jeroenleenarts
force-pushed
the
CIS-1273-check-optionals
branch
from
e277ffd
to
f985f5c
Compare
bielikb
previously approved these changes
Dec 13, 2021
polqf
reviewed
Dec 13, 2021
jeroenleenarts
force-pushed
the
CIS-1273-check-optionals
branch
from
f985f5c
to
207d74a
Compare
bielikb
previously approved these changes
Dec 15, 2021
polqf
reviewed
Dec 15, 2021
| @NSManaged private var localProgress: Double | ||
| var localState: LocalAttachmentState? { | ||
| get { | ||
| localStateRaw.flatMap { LocalAttachmentState(rawValue: $0, progress: localProgress) } | ||
| LocalAttachmentState(rawValue: localStateRaw, progress: localProgress) |
There was a problem hiding this comment.
What about LocalAttachmentState(rawValue: localStateRaw, progress: localProgress) ?? .unknown so we don't expose an optional?
jeroenleenarts
force-pushed
the
CIS-1273-check-optionals
branch
2 times, most recently
from
58edc61
to
9237c13
Compare
bielikb
approved these changes
Dec 17, 2021
jeroenleenarts
force-pushed
the
CIS-1273-check-optionals
branch
from
9237c13
to
d858e5e
Compare
- Uses sensible defaults when possible - Unit tests are also adjusted - Populate `ownReactions` and `latestReactions` on MessageDTO when creating a new object, they are non-optinal on the Core Data Model - Mark `MessageReactionDTO.id` and `MessageDTO.quotedMessage` and `ChannelDto.typeRawValue as non-optional - Make localStateRaw non optional on both the MessageReactionDTO and the AttachmentDTO.
jeroenleenarts
force-pushed
the
CIS-1273-check-optionals
branch
from
d858e5e
to
bb70a8a
Compare
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Issue Link
CIS-1273
🎯 Goal
A number of differences between the Core Data model and the ManagedObjects were present. This pull request removes those issues. When applicable a sensible default is chosen for what Core Data describes as primitive types.
🛠 Implementation
Several model definitions were changed, several managed object classes were changed, several sensible default values were chosen.
🧪 Testing
Run through the app. No crashes should occur.
🎨 Changes
Add relevant screenshots or videos showcasing the changes.
☑️ Checklist