New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CIS-1459] Make Data Formatters Configurable #1742
[CIS-1459] Make Data Formatters Configurable #1742
Conversation
…ble-to-allow-customization
Codecov Report
@@ Coverage Diff @@
## develop #1742 +/- ##
========================================
Coverage 85.39% 85.39%
========================================
Files 234 234
Lines 11247 11247
========================================
Hits 9604 9604
Misses 1643 1643
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Sources/StreamChatUI/ChatMessageList/ChatMessage/ChatMessageContentView.swift
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should add something to the SDK docs about this
Will add the docs once we define the final API 👍 |
Congratulations! This change reduces app size by 1.6 MB🗂 See the Emerge breakdown
🔎 See the full analysis (84c64ae) merging into develop (fe82d44)
|
Converted to draft, since there will be some team discussions on the API |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job @nuno-vieira. I left two doc suggestions
Sources/StreamChatUI/Appearance+Formatters/MessageDateSeparatorFormatter.swift
Outdated
Show resolved
Hide resolved
Co-authored-by: Boris Bielik <h3sperian@gmail.com>
…ble-to-allow-customization
Docs are now available 👍 |
🔗 Issue Link
CIS-1459
#1739
🎯 Goal
Provide a way to change the data formatting in the SDK.
🛠 Implementation
Expose all formatters in the
Appearance
configuration through theAppearance.default.formatters
. Each formatter is represented by a Protocol so that the customer can provide their own implementation or change the default ones.🎨 Changes
N/A
🧪 Testing
Example on how to change a default formatter:
Example on how to provide a custom formatter:
☑️ Checklist