[CIS-1288] Fix Message List NSInternalInconsistencyException Crash

[nuno-vieira]

🔗 Issue Link

CIS-1288

🎯 Goal

Fix a crash that happened when switching channels very quickly, and when the messages were not prefetched from a channel list.

🛠 Implementation

Call reloadData() when the data source of the message list is changed. When switching channels in quick succession it could happen that there were conflicts in the message list with the old data in case the ChatChannelVC was reused.

🎨 Changes

N/A

🧪 Testing

Steps to reproduce this:

1. Apply this patch: dontSaveChannelListMessages.patch.zip
2. Open the demo app with an iPad (Easier to quickly switch channels)
3. Quickly switch channels
4. Observe there are no crashes.

In order to reproduce the crash, make sure to revert this PR and delete the reloadData() from here: DemoAppCoordinatior.swift#L167 (This is why it was really hard to reproduce this issue because we were fixing it on the demo app).

☑️ Checklist

• I have signed the Stream CLA (required)
• This change follows zero ⚠️ policy (required)
• Changelog is updated with client-facing changes

[codecov]

Codecov Report

Merging #1752 (d854f9d) into develop (6672eb8) will decrease coverage by 0.08%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #1752      +/-   ##
===========================================
- Coverage    85.45%   85.36%   -0.09%     
===========================================
  Files          234      234              
  Lines        11247    11247              
===========================================
- Hits          9611     9601      -10     
- Misses        1636     1646      +10     

Flag	Coverage Δ
llc-tests	85.36% <ø> (-0.09%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
Sources/StreamChat/Utils/Logger/Logger.swift	56.28% <0.00%> (-5.99%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6672eb8...d854f9d. Read the comment docs.

[bielikb]

LGTM 🚢