[CIS-1489] Fix Image and Video sharing behaviour

[nuno-vieira]

🔗 Issue Link

CIS-1489

🎯 Goal

When sharing a video or image, it should not share an URL, but the asset itself.

🛠 Implementation

When it is an image, we share the actual UIImage. When it is a video, we share the actual video file.

🎨 Changes

RPReplay_Final1641930184.MP4

🧪 Testing

• Tap on a video/image
• Tap share
• Click on "mail"
• The video/image should appear on the content of the email instead of an URL

☑️ Checklist

• I have signed the Stream CLA (required)
• This change follows zero ⚠️ policy (required)
• Changelog is updated with client-facing changes
• New code is covered by unit tests
• Affected documentation updated (docusaurus, tutorial, CMS (task created)

[codecov]

Codecov Report

Merging #1753 (bd51152) into develop (37fe552) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #1753   +/-   ##
========================================
  Coverage    85.39%   85.39%           
========================================
  Files          234      234           
  Lines        11247    11247           
========================================
  Hits          9604     9604           
  Misses        1643     1643           

Flag	Coverage Δ
llc-tests	85.39% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37fe552...bd51152. Read the comment docs.

[b-onc]

Tapping "share" button and seeing the sharing sheet has 2 seconds delay. Many apps on iOS has that, but is there a way to escape that?

[nuno-vieira]

Tapping "share" button and seeing the sharing sheet has 2 seconds delay. Many apps on iOS has that, but is there a way to escape that?

Yes that is normal. The only way to improve this is to add a spinner or maybe compress the quality. Right now this PR is to make the fix ASAP since we have customers waiting on this. But I’m going to create a ticket to make this feature complete, like adding missing attachments, improve the code quality and investigate if we can make the sheet a little bit faster, as well as cleaning up temp resources 👍