Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CIS-1549] Make ChannelId.rawValue public #1780

Merged
merged 2 commits into from Feb 7, 2022

Conversation

nuno-vieira
Copy link
Member

@nuno-vieira nuno-vieira commented Feb 4, 2022

🔗 Issue Link

CIS-1549

🎯 Goal

Simple one-liner, just to fix the ChannelId.rawValue access control.

🛠 Implementation

Change ChannelId.rawValue access control to public.

🎨 Changes

N/A

🧪 Testing

N/A

☑️ Checklist

  • I have signed the Stream CLA (required)
  • This change follows zero ⚠️ policy (required)
  • Changelog is updated with client-facing changes

@nuno-vieira nuno-vieira requested a review from a team February 4, 2022 16:22
@nuno-vieira nuno-vieira changed the title [CIS-1549] Make ChannelId.rawValue public [CIS-1549] Make ChannelId.rawValue public Feb 4, 2022
@codecov
Copy link

codecov bot commented Feb 4, 2022

Codecov Report

Merging #1780 (6b7a660) into develop (61b87c7) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1780   +/-   ##
========================================
  Coverage    85.41%   85.41%           
========================================
  Files          234      234           
  Lines        11261    11261           
========================================
  Hits          9619     9619           
  Misses        1642     1642           
Flag Coverage Δ
llc-tests 85.41% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
Sources/StreamChat/Models/ChannelId.swift 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61b87c7...6b7a660. Read the comment docs.

Copy link
Contributor

@adamrushy adamrushy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅ thanks for jumping on this one

@nuno-vieira nuno-vieira merged commit 292c84d into develop Feb 7, 2022
@nuno-vieira nuno-vieira deleted the fix/CIS-1549-Make-channelId-rawValue-public branch February 7, 2022 11:09
@nuno-vieira nuno-vieira mentioned this pull request Feb 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants