New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CIS-1592] Fix file mime-types and attachment type #1873
[CIS-1592] Fix file mime-types and attachment type #1873
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚢
04dd086
to
1559687
Compare
Co-authored-by: Pavel Evsaev <pavel.evsaev@gmail.com>
Converted to draft to make sure we should do: "When adding a file from the File Picker, resolve the correct attachment type" |
Codecov Report
@@ Coverage Diff @@
## develop #1873 +/- ##
===========================================
- Coverage 86.00% 85.94% -0.06%
===========================================
Files 237 238 +1
Lines 11526 11556 +30
===========================================
+ Hits 9913 9932 +19
- Misses 1613 1624 +11
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
…swift into feature/sync-with-main * 'main' of https://github.com/timeless-space/stream-chat-swift: (24 commits) Update CHANGELOG.md [CIS-1737] Fix deadlock when accessing some properties from Events Delegate (GetStream#1898) Bump 4.13.1 Update CHANGELOG.md Bump 4.13.0 Update CHANGELOG.md [CIS-1655] Do not fail decoding `removed_from_channel` event if channel is incomplete (GetStream#1881) Move UI Kit Customizing Components doc to main level (GetStream#1883) Docs updates for the SwiftUI SDK (GetStream#1882) [CIS-1189] Fix long file names overlapped by the close button (GetStream#1880) [CIS-1702] Add Mixed Attachments UI Support (GetStream#1877) [CIS-1523] Create mock web socket client for UI tests (GetStream#1866) [CIS-1694] Introduce message translations (GetStream#1867) Fix pasting long text into composer won't update input height (GetStream#1876) Fix command with no arg can be sent without text (GetStream#1869) [CIS-1592] Fix file mime-types and attachment type (GetStream#1873) [CIS-1689] Add support for multiple push providers (GetStream#1864) [CIS-1285] Start collecting iOS version (GetStream#1846) Improved wording in summary to give us a fighting chance when indexing at cocoapods.org [CIS-1679] Fix payload for reaction when using enforce_unique (GetStream#1861) ... # Conflicts: # Package.swift # Sources/StreamChat/Models/ChatMessage.swift # Sources/StreamChatUI/ChatChannelList/ChatChannelListItemView.swift # Sources/StreamChatUI/ChatChannelList/ChatChannelListVC.swift # Sources/StreamChatUI/ChatMessageList/ChatMessage/ChatMessageCell.swift # Sources/StreamChatUI/Composer/ComposerVC.swift # StreamChat.xcodeproj/project.pbxproj # StreamChatUI.podspec
🔗 Issue Link
CIS-1592
🎯 Goal
🛠 Implementation
🎨 UI Changes
Adding an image through the file picker:
ResolvingAttachmentType.mp4
🧪 Testing
Scenario 1:
.rtf
text/rtf
Scenario 2:
Note: When importing audio files from the File Picker, nothing will render
since we currently don't support audio files in the iOS SDK
☑️ Contributor Checklist