New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CIS-1131] Support marking all channels as read at a user level #1927
Conversation
🚨 This change increases app size by 2.5 kB🗂 See the Emerge breakdown
🔎 See the full analysis (85a6a11) merging into develop (09114ea)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done @adolfogarza 👍 Let's check with @bielikb @alteral that GIVEN/WHEN/THEN
were supposed to be used not only in UI tests. Once it's resolved, I'll approve 🙂
Tests/StreamChatTests/Controllers/CurrentUserController/CurrentUserController_Tests.swift
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢
Kudos, SonarCloud Quality Gate passed! |
🔗 Issue Link
CIS-1131
🎯 Goal
The goal is to relocate
markAllRead()
from theChannelListController
toCurrentUserController
to have parity with other platforms.🛠 Implementation
The
markAllRead()
call has been relocated toCurrentUserController
, the specific implementation has been moved toCurrentUserUpdater
to be consistent with the current architecture. Tests have been included to cover typical use cases. The currentmarkAllRead()
has been marked as deprecated in order to not disturb current implementors of that call, but let them know that there is a better way to do that now📝 Changes
_ N/A
🎨 UI Changes
N/A
🧪 Testing
Since this method not used in the demo app or in the UI SDK by default, a very simple way to test this is to generate new messages on multiple channels that your user belongs to, then call
ChatClient.shared.currentUserController().markAllRead()
onDemoChannelListVC
atviewDidLoad
and you should be able to see how these are marked as read.☑️ Contributor Checklist