New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CIS-1888] Fix DM Channel with multiple members displaying only 1 user avatar #2019
Merged
nuno-vieira
merged 3 commits into
develop
from
fix/CIS-1888-DM-Channel-with-multiple-members-shows-1-user-image
May 24, 2022
Merged
[CIS-1888] Fix DM Channel with multiple members displaying only 1 user avatar #2019
nuno-vieira
merged 3 commits into
develop
from
fix/CIS-1888-DM-Channel-with-multiple-members-shows-1-user-image
May 24, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nuno-vieira
added
🐞 Bug
An issue or PR related to a bug
🎨 SDK: StreamChatUI
Tasks related to the StreamChatUI SDK
labels
May 23, 2022
nuno-vieira
force-pushed
the
fix/CIS-1888-DM-Channel-with-multiple-members-shows-1-user-image
branch
from
May 23, 2022 17:49
923ccbc
to
f7854d8
Compare
evsaev
approved these changes
May 24, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢
Tests/StreamChatTestTools/Mocks/Models + Extensions/ChatChannel_Mock.swift
Outdated
Show resolved
Hide resolved
Kudos, SonarCloud Quality Gate passed! |
⬆️ This change increases install size by 22.4 kB ⬆️🗂 See the Emerge size breakdown
🔎 See the full analysis (85143a9) merging into develop (00da858)
|
bielikb
approved these changes
May 24, 2022
nuno-vieira
deleted the
fix/CIS-1888-DM-Channel-with-multiple-members-shows-1-user-image
branch
May 24, 2022 12:15
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Issue Links
CIS-1888
🎯 Goal
Fix issue of DM Channel with multiple members and without channel image assigned showing the image of only one member instead of showing the merged avatar.
🛠 Implementation
Instead of using
isDirectMessageChannel
to show 1:1 avatar image for the channel, do this only if the memberCount is 2.🎨 Showcase
The change can be seen in the new snapshot test added 👍
🧪 Manual Testing Notes
☑️ Contributor Checklist