Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CIS-1529] Fix quoted message adding extra top spacing #2050

Merged
merged 4 commits into from Jun 2, 2022

Conversation

nuno-vieira
Copy link
Member

@nuno-vieira nuno-vieira commented Jun 2, 2022

馃敆 Issue Links

CIS-1529
#1762

馃幆 Goal

Fixes quoted message list UI flicker bug. This was caused because there was an extra margin-top in the quoted message view. Sometimes the cell would reload and cause this jump, but sometimes the jump wouldn't happen but the cell with have extra padding, and only after scrolling it would go away.

馃摑 Summary

馃帹 Showcase

image

Before After
image image

馃И Manual Testing Notes

  • Add a normal message
  • Quote the normal message
  • There shouldn't be any gap between the normal and quoted message

鈽戯笍 Contributor Checklist

  • I have signed the Stream CLA (required)
  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • This change follows zero 鈿狅笍 policy (required)
  • Comparison screenshots added for visual changes
  • Affected documentation updated (docusaurus, tutorial, CMS)

Also removes all margins to be more aligned with Figma designs
@nuno-vieira nuno-vieira added 馃悶聽Bug An issue or PR related to a bug 馃帹聽SDK: StreamChatUI Tasks related to the StreamChatUI SDK labels Jun 2, 2022
@nuno-vieira nuno-vieira requested a review from a team as a code owner June 2, 2022 16:46
Copy link
Contributor

@evsaev evsaev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 馃憦

@sonarcloud
Copy link

sonarcloud bot commented Jun 2, 2022

Kudos, SonarCloud Quality Gate passed!聽 聽 Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@nuno-vieira nuno-vieira merged commit 5561750 into develop Jun 2, 2022
@nuno-vieira nuno-vieira deleted the fix/CIS-1529-Quoted-Message-Flicker-UI-Bug branch June 2, 2022 19:39
This was referenced Jun 6, 2022
@bielikb bielikb mentioned this pull request Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
馃悶聽Bug An issue or PR related to a bug 馃帹聽SDK: StreamChatUI Tasks related to the StreamChatUI SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants