Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

One endpoint to rule them all #2125

Merged
merged 3 commits into from Jun 28, 2022
Merged

One endpoint to rule them all #2125

merged 3 commits into from Jun 28, 2022

Conversation

bielikb
Copy link
Contributor

@bielikb bielikb commented Jun 27, 2022 •
edited

🎯 Goal

Leverage single https://chat.stream-io-api.com/ mediator.

📝 Summary

Previously the integrator could select the endpoint to connect to based on the preferred location.
By providing a single endpoint the client no longer needs to think about the closest proxy server.
New endpoint acts as a mediator that connects the end-user to the closest server with the best latency.

🧪 Manual Testing Notes

Run the app and verify all works fine.

☑️ Contributor Checklist

  • I have signed the Stream CLA (required)
  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • This change follows zero ⚠️ policy (required)
  • Comparison screenshots added for visual changes
  • Affected documentation updated (docusaurus, tutorial, CMS)

🎁 Meme

Provide a funny gif or image that relates to your work on this pull request. (Optional)

@bielikb bielikb force-pushed the feature/one-endpoint-to-rule-them-all branch from a414245 to 44f4947 Compare June 28, 2022 07:44
@bielikb bielikb force-pushed the feature/one-endpoint-to-rule-them-all branch from 44f4947 to 75e1160 Compare June 28, 2022 07:50
@bielikb bielikb marked this pull request as ready for review June 28, 2022 07:52
@bielikb bielikb requested a review from a team as a code owner June 28, 2022 07:52
@GetStream GetStream deleted a comment from Stream-iOS-Bot Jun 28, 2022
bielikb
bielikb commented Jun 28, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
adamrushy
adamrushy approved these changes Jun 28, 2022
View reviewed changes
Copy link
Contributor

@adamrushy adamrushy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@sonarcloud
Copy link

sonarcloud bot commented Jun 28, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@bielikb bielikb merged commit 5330359 into develop Jun 28, 2022
@bielikb bielikb deleted the feature/one-endpoint-to-rule-them-all branch June 28, 2022 09:03
@nuno-vieira nuno-vieira mentioned this pull request Jul 5, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamrushy adamrushy adamrushy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bielikb @adamrushy