Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for move operations to scroll to the bottom of the message list #2130

Merged
merged 4 commits into from Jul 2, 2022

Conversation

adolfogarza
Copy link
Contributor

馃敆 Issue Links

https://stream-io.atlassian.net/browse/CIS-1600
https://stream-io.atlassian.net/browse/CIS-1781

馃幆 Goal

Allow for move operations to scroll to the bottom of the message list

鈽戯笍 Contributor Checklist

  • I have signed the Stream CLA (required)
  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • This change follows zero 鈿狅笍 policy (required)
  • Comparison screenshots added for visual changes
  • Affected documentation updated (docusaurus, tutorial, CMS)

@adolfogarza adolfogarza requested a review from a team as a code owner June 28, 2022 21:59
@bielikb
Copy link
Contributor

bielikb commented Jun 29, 2022

Hey @adolfogarza,

I QAd this PR. The list is correctly scrolled to the bottom in both scenarios. Could you please cover this bugfix with 2 simple UI tests?

You could follow similar approach as this test.

@sonarcloud
Copy link

sonarcloud bot commented Jul 1, 2022

Kudos, SonarCloud Quality Gate passed!聽 聽 Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@adolfogarza adolfogarza merged commit bad8e20 into develop Jul 2, 2022
@adolfogarza adolfogarza deleted the bugfix/CIS-1600 branch July 2, 2022 19:53
@nuno-vieira nuno-vieira mentioned this pull request Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants