Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix deadlock caused by ListDatabaseObserver.startObserving() changes #2252

Merged
merged 2 commits into from Aug 26, 2022
Merged

Fix deadlock caused by ListDatabaseObserver.startObserving() changes #2252

merged 2 commits into from Aug 26, 2022

Conversation

nuno-vieira
Copy link
Member

@nuno-vieira nuno-vieira commented Aug 26, 2022 •
edited

🔗 Issue Links

None

🎯 Goal

This PR reverts this change: #2177 which caused a deadlock in @CoreDataLazy because of the usage of @Atomic. Besides this, that change also makes the Channel List Loading less performant because the LazyCachedCollection is not really being used, and it is not lazy with that change.

With the newly introduced logout() the fix above is not needed anymore, since we can guarantee there won't be nullable items.

☑️ Contributor Checklist

  • I have signed the Stream CLA (required)
  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • This change follows zero ⚠️ policy (required)
  • Comparison screenshots added for visual changes
  • Affected documentation updated (docusaurus, tutorial, CMS)

@nuno-vieira nuno-vieira added 🐞 Bug An issue or PR related to a bug 🌐 SDK: StreamChat (LLC) Tasks related to the StreamChat LLC SDK labels Aug 26, 2022
@nuno-vieira nuno-vieira requested a review from a team as a code owner August 26, 2022 10:30
@Stream-iOS-Bot
Copy link
Collaborator

1 Message
📖 There seems to be app changes but CHANGELOG wasn't modified.
Please include an entry if the PR includes user-facing changes.
You can find it at CHANGELOG.md.

Generated by 🚫 Danger

@nuno-vieira nuno-vieira merged commit c1b65c8 into develop Aug 26, 2022
@nuno-vieira nuno-vieira deleted the fix/deadlock-in-CoreDataLazy branch August 26, 2022 10:38
@sonarcloud
Copy link

sonarcloud bot commented Aug 26, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

80.0% 80.0% Coverage
0.0% 0.0% Duplication

@polqf polqf mentioned this pull request Sep 1, 2022
Merged
polqf pushed a commit that referenced this pull request Sep 1, 2022
@nuno-vieira @polqf
Fix deadlock caused by ListDatabaseObserver.startObserving() changes (#…
9ca45e4 
…2252)

* Revert "[CIS-2052] Fix crash in ListDatabaseObserver.startObserving() (#2177)"

This reverts commit aa25375.

* Update CHANGELOG.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@polqf polqf polqf approved these changes

Assignees
No one assigned
Labels
🐞 Bug An issue or PR related to a bug 🌐 SDK: StreamChat (LLC) Tasks related to the StreamChat LLC SDK
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nuno-vieira @Stream-iOS-Bot @polqf