Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CurrentChatUserController+Combine: Use controller.unreadCount as initial value instead of .noUnread #2334

Merged
merged 6 commits into from Oct 19, 2022
Merged

CurrentChatUserController+Combine: Use controller.unreadCount as initial value instead of .noUnread #2334

merged 6 commits into from Oct 19, 2022

Conversation

Aurazion
Copy link
Contributor

@Aurazion Aurazion commented Oct 14, 2022 •
edited

🎯 Goal

Currently unreadCountPublisher is instantiated using .noUnread value, and until the user got a new message for example, the value remains at 0.
Use controller.unreadCount as initial value instead of .noUnread to provide previous stored value, if any.

☑️ Contributor Checklist

  • I have signed the Stream CLA (required)
  • This change follows zero ⚠️ policy (required)
  • This change should be manually QAed
  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Comparison screenshots added for visual changes
  • Affected documentation updated (docusaurus, tutorial, CMS)

🎁 Meme

@Aurazion Aurazion requested a review from a team as a code owner October 14, 2022 15:55
nuno-vieira
nuno-vieira reviewed Oct 18, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
nuno-vieira
nuno-vieira approved these changes Oct 18, 2022
View reviewed changes
Copy link
Member

@nuno-vieira nuno-vieira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✅

@nuno-vieira nuno-vieira merged commit 6878551 into GetStream:develop Oct 19, 2022
@nuno-vieira nuno-vieira mentioned this pull request Oct 27, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nuno-vieira nuno-vieira nuno-vieira approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Aurazion @nuno-vieira