CIS-115 Test old iOS SDKs nightly #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
May 6, 2020 14:20
since it doesn't access network
By default, it'll retry up to 3 times to make sure the failure is actually a failure
For some reason our carthage cache is invalid, only fix is to change key
b-onc
added
🙏 Feature Request
Closed
|
Why did you select 11.4? |
|
@buh Latest version of each iOS SDK makes the most sense, we can't support all versions of iOS 11 and 12. Most users will be on the latest update of major version anyway. If they're not, the solution is simple -> Please update to latest iOS 11/12 |
buh
approved these changes
May 6, 2020
VojtaStavik
approved these changes
May 6, 2020
| @@ -135,6 +135,25 @@ lane :test_without_building do | |||
| scan(project: "StreamChat.xcodeproj", scheme: "StreamChat", test_without_building: true, only_testing: ["StreamChatClientTests"]) | |||
| end | |||
|
|
|||
| desc "Runs integrations tests with backend. These tests make network connections so they're sometimes not reliable, hence we run them up to 3 times in case of failure" | |||
| lane :test_backend_integration do |options| | |||
| @test_retries = 3 | |||
|
@b-onc I realized we don't run unit tests, only integration tests. Is that on purpose? |
That was on error, I've updated PR |
Also fix somehow broken ClientLogger test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test run here: https://github.com/GetStream/stream-chat-swift/runs/649869791?check_suite_focus=true
We're able to test iOS 11.4 and 12.4 (in parallel!), and we're using (we have to) backend integration test. The reported iOS12 crash was related to network request part, so I thought this makes sense to have!
Oh, also moved ClientLogger tests to Unit tests target since it was a unit test.