Removed forced optional type used in Atomic
#254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b-onc
approved these changes
May 8, 2020
CHANGELOG.md
Outdated
Comment on lines
9
to
11
| ### 鈿狅笍 Breaking Changes | ||
| - `Atomic.get()` no longer returns an optional type if the wrapped type itself is not optional. `Atomic.init(_:)` now always requires the initial value [#241](https://github.com/GetStream/stream-chat-swift/issues/241). | ||
|
|
There was a problem hiding this comment.
Maybe we should merge this into release/3.0 since it's breaking and touches a lot of different parts?
There was a problem hiding this comment.
I'd like to merge it to master. Let me redo it in a bit more compatible way.
buh
approved these changes
May 8, 2020
VojtaStavik
force-pushed
the
remove-atomic-optional
branch
2 times, most recently
from
2cb72f3
to
3597392
Compare
VojtaStavik
commented
May 8, 2020
| DispatchQueue.random.async { | ||
| // We need to capture the value explicitly. Without this the tests randomly crashes after | ||
| // `atomicValue` is assigned to `nil`. | ||
| DispatchQueue.random.async { [atomicValue] in |
There was a problem hiding this comment.
10 minutes to identify the problem + 50 minutes figuring out how to fix it = [atomicValue]
b-onc
approved these changes
May 8, 2020
Comment on lines
+13
to
+14
| /// - Note: Even though the value guarded by `Atomic` is thread-safe, the `Atomic` class itself is not. Mutating the instance | ||
| /// itself from multiple threads can cause a crash. |
|
@b-onc As far as I understand it, capturing it explicitly creates a strong reference to |
VojtaStavik
force-pushed
the
remove-atomic-optional
branch
from
3597392
to
1ad03e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the PR:
valueinAtomicis no longer treated asOptionalby defaultAtomicstress tests random crash (hopefully) fixed 馃@buh @b-onc Please review and test this extremely carefully. I touched a lot of different parts of the app and could easily introduce some copy-paste/typo kind of bug 馃檹