Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow replies to soft-deleted messages #2633

Merged
merged 4 commits into from May 22, 2023

Conversation

polqf
Copy link
Contributor

@polqf polqf commented May 19, 2023

🔗 Issue Links

https://github.com/GetStream/ios-issues-tracking/issues/407

🎯 Goal

Allow replies for soft-deleted messages

📝 Summary

Up until now, we were not showing the UI to access thread replies for soft deleted messages. This was not allowing a UX flow to add more replies to it.
This PR aims to allow access to a thread when there are replies to a soft deleted message

🎨 Showcase

Uploading Screenshot 2023-05-19 at 17.52.40.png…

🧪 Manual Testing Notes

  1. Send a message
  2. Add a thread reply to it
  3. Remove root message

Expected results:

  1. The deleted message cell should indicate that there are replies to it
  2. You should be able to access the thread
  3. You should be able to send new replies to it

☑️ Contributor Checklist

  • I have signed the Stream CLA (required)
  • This change follows zero ⚠️ policy (required)
  • This change should be manually QAed
  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Comparison screenshots added for visual changes
  • Affected documentation updated (docusaurus, tutorial, CMS)

🎁 Meme

@polqf polqf requested a review from a team as a code owner May 19, 2023 15:55
@polqf polqf changed the title Allow replies for soft-deleted messages Allow replies to soft-deleted messages May 19, 2023
CHANGELOG.md Outdated Show resolved Hide resolved
polqf and others added 2 commits May 22, 2023 13:47
Co-authored-by: Nuno Vieira <nuno.fcvieira93@gmail.com>
Copy link
Member

@nuno-vieira nuno-vieira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✅

@sonarcloud
Copy link

sonarcloud bot commented May 22, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@polqf polqf merged commit d3a4006 into develop May 22, 2023
17 checks passed
@polqf polqf deleted the feature/allow-replies-to-soft-deleted-messages branch May 22, 2023 14:38
@nuno-vieira nuno-vieira mentioned this pull request May 24, 2023
This was referenced May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants