Fix muted and joined channel list queries with empty data (Auto Filtering Enabled) #2634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nuno-vieira
added
🐞 Bug
ipavlidakis
approved these changes
May 22, 2023
| @@ -111,13 +111,19 @@ public struct Filter<Scope: FilterScope> { | |||
| /// Whether the `keyPathString` represents an array in the DTO entities. | |||
| let isCollectionFilter: Bool | |||
|
|
|||
| /// The mapper that will override the DB Predicate. This might be needed | |||
There was a problem hiding this comment.
The comment is very helpful. Thanks for adding it!
polqf
approved these changes
May 22, 2023
| switch op { | ||
| case .equal: | ||
| return NSPredicate(format: muted ? "\(key) != nil" : "\(key) == nil") | ||
| default: |
There was a problem hiding this comment.
The code looks the same in both implementations (but the keyPath). Should we be reusing it by placing it in a single place? We are probably using the same logic in other places?
There was a problem hiding this comment.
For now, I think it is fine to have a little duplication. We can introduce a helper to reuse this logic if we see more use cases like this. 👍
|
Kudos, SonarCloud Quality Gate passed! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Issue Links
Resolves https://github.com/GetStream/ios-issues-tracking/issues/423
🎯 Goal
Fix the channel list query being empty when the
.mutedand.joinedfilters were used with auto filtering enabled.🛠 Implementation
We currently have an issue with our Auto Filtering where the
.mutedand.joinedfilters do not properly map to our DB predicates.After some analysis and discussion with @ipavlidakis, we opted for introducing a
PredicateMapperso that a filter can override the default Predicate logic.🧪 Manual Testing Notes
Unit tests were added to prove it works correctly.
☑️ Contributor Checklist