Add support for thread view not rendering parent message #2636
Conversation
nuno-vieira
added
🎨 SDK: StreamChatUI
|
Kudos, SonarCloud Quality Gate passed!
|
| @@ -106,6 +106,34 @@ final class ChatThreadVC_Tests: XCTestCase { | |||
| ) | |||
| } | |||
|
|
|||
| func test_whenThreadRendersParentMessageEnabledIsFalse() { | |||
There was a problem hiding this comment.
nit: Shall we add something as the expected result? Something like
test_whenThreadRendersParentMessageEnabledIsFalse_parentMessageWontRender?
There was a problem hiding this comment.
I've opted to follow the same pattern in the rest of the tests in ChatThreadVC_Tests, for example: test_whenShouldMessagesStartAtTheTopIsTrue()
When the expected result is too obvious, I don't mind omitting it, but I don't mind being explicit, either. I think, in the end, it is just personal taste.
In this case, because it is consistent with the rest of the tests in this class, I'm willing not to change it, but let me know if you have a different opinion 👍
nuno-vieira
deleted the
add/add-support-for-thread-view-not-rendering-parent-message
branch
🔗 Issue Links
Resolves https://github.com/GetStream/ios-issues-tracking/issues/413
🎯 Goal
Adds a new flag to disable rendering the root message in the Thread View.
📝 Summary
Components.threadRendersParentMessageEnabledflag☑️ Contributor Checklist