New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for jumping to message inside threads from channel view #2647
Merged
nuno-vieira
merged 17 commits into
develop
from
add/jumping-to-message-inside-threads-from-channel-view
May 30, 2023
Merged
Add support for jumping to message inside threads from channel view #2647
nuno-vieira
merged 17 commits into
develop
from
add/jumping-to-message-inside-threads-from-channel-view
May 30, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nuno-vieira
added
🎨 SDK: StreamChatUI
Tasks related to the StreamChatUI SDK
✅ Feature
An issue or PR related to a feature
labels
May 24, 2023
polqf
approved these changes
May 29, 2023
Kudos, SonarCloud Quality Gate passed! |
testableapple
added
🟢 QAed
A PR that was QAed
and removed
🤞 Ready For QA
A PR that is Ready for QA
labels
May 30, 2023
testableapple
approved these changes
May 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚢
nuno-vieira
force-pushed
the
add/jumping-to-message-inside-threads-from-channel-view
branch
from
May 30, 2023 13:03
7eeea50
to
c97c571
Compare
nuno-vieira
deleted the
add/jumping-to-message-inside-threads-from-channel-view
branch
May 30, 2023 13:54
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
✅ Feature
An issue or PR related to a feature
🟢 QAed
A PR that was QAed
🎨 SDK: StreamChatUI
Tasks related to the StreamChatUI SDK
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Issue Links
Resolves https://github.com/GetStream/ios-issues-tracking/issues/384
🎯 Goal
Jump to reply inside a thread from the channel view.
📝 Summary
.around
and the given message is a replyId🧪 Manual Testing Notes
New ACs:
🎨 Showcase
Simulator.Screen.Recording.-.iPhone.14.Pro.-.2023-05-24.at.18.25.01.mp4
Simulator.Screen.Recording.-.iPhone.14.Pro.-.2023-05-24.at.18.26.50.mp4
Simulator.Screen.Recording.-.iPhone.14.Pro.-.2023-05-24.at.18.28.23.mp4
☑️ Contributor Checklist