Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for jumping to message inside threads from channel view #2647

Merged

Conversation

nuno-vieira
Copy link
Member

@nuno-vieira nuno-vieira commented May 24, 2023

🔗 Issue Links

Resolves https://github.com/GetStream/ios-issues-tracking/issues/384

🎯 Goal

Jump to reply inside a thread from the channel view.

📝 Summary

  • Adds jumping to a reply inside a thread when tapping a quoted message which is inside a thread
  • Adds jumping to a reply inside a thread when opening a thread from a thread reply in the channel view
  • Adds jumping to a reply inside a thread when opening a channel with pagination of .around and the given message is a replyId

🧪 Manual Testing Notes

New ACs:

  1. When I tap on quoted message, which is inside a thread reply, it should open the thread and jump to the thread reply
  2. When opening a thread from a thread reply which was also sent to the channel, it should open the thread and jump to the reply
  3. When I open a channel where the initial pagination is .around(replyId), it should open the channel in the parent message location, open the thread and jump to the reply id

🎨 Showcase

AC.1 AC.2 AC.3
Simulator.Screen.Recording.-.iPhone.14.Pro.-.2023-05-24.at.18.25.01.mp4
Simulator.Screen.Recording.-.iPhone.14.Pro.-.2023-05-24.at.18.26.50.mp4
Simulator.Screen.Recording.-.iPhone.14.Pro.-.2023-05-24.at.18.28.23.mp4

☑️ Contributor Checklist

  • I have signed the Stream CLA (required)
  • This change follows zero ⚠️ policy (required)
  • This change should be manually QAed
  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Comparison screenshots added for visual changes
  • Affected documentation updated (docusaurus, tutorial, CMS)

@nuno-vieira nuno-vieira added 🎨 SDK: StreamChatUI Tasks related to the StreamChatUI SDK ✅ Feature An issue or PR related to a feature labels May 24, 2023
@nuno-vieira nuno-vieira requested a review from a team as a code owner May 24, 2023 17:36
@testableapple testableapple added the 🤞 Ready For QA A PR that is Ready for QA label May 29, 2023
@sonarcloud
Copy link

sonarcloud bot commented May 29, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@testableapple testableapple added 🟢 QAed A PR that was QAed and removed 🤞 Ready For QA A PR that is Ready for QA labels May 30, 2023
Copy link
Contributor

@testableapple testableapple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚢

@nuno-vieira nuno-vieira force-pushed the add/jumping-to-message-inside-threads-from-channel-view branch from 7eeea50 to c97c571 Compare May 30, 2023 13:03
@nuno-vieira nuno-vieira merged commit d2ecf33 into develop May 30, 2023
12 of 15 checks passed
@nuno-vieira nuno-vieira deleted the add/jumping-to-message-inside-threads-from-channel-view branch May 30, 2023 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✅ Feature An issue or PR related to a feature 🟢 QAed A PR that was QAed 🎨 SDK: StreamChatUI Tasks related to the StreamChatUI SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants