New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix shadow message making hidden channel reappear #2663

Merged

nuno-vieira merged 2 commits into develop from fix/shadow-message-makes-hidden-channel-appear

Jun 1, 2023

Member

nuno-vieira commented Jun 1, 2023 •

edited

🔗 Issue Links

Resolves https://github.com/GetStream/ios-issues-tracking/issues/425

🎯 Goal

Fix shadow message making hidden channel reappear.

🧪 Manual Testing Notes

It is easier to test this with this PR merged: #2660

User A shadow bans User B
User A hides a channel
User B sends a message to the channel
Channel should still be hidden for User A

☑️ Contributor Checklist

I have signed the Stream CLA (required)
This change follows zero ⚠️ policy (required)
This change should be manually QAed
Changelog is updated with client-facing changes
New code is covered by unit tests
Comparison screenshots added for visual changes
Affected documentation updated (docusaurus, tutorial, CMS)


          Fix shadow message making hidden channel reappear

b34ca72

nuno-vieira added 🐞 Bug 🌐 SDK: StreamChat (LLC) labels

nuno-vieira requested a review from a team as a code owner

June 1, 2023 13:58


          Update CHANGELOG.md

09233b7

polqf approved these changes

View reviewed changes

sonarcloud bot commented Jun 1, 2023

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell

100.0% Coverage
0.0% Duplication

nuno-vieira merged commit ccf563e into develop

17 checks passed

nuno-vieira deleted the fix/shadow-message-makes-hidden-channel-appear branch

June 1, 2023 15:03

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment