Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose Extra Data for Giphy Attachment Payloads #2678

Merged
merged 3 commits into from Jun 21, 2023
Merged

Expose Extra Data for Giphy Attachment Payloads #2678

merged 3 commits into from Jun 21, 2023

Conversation

nuno-vieira
Copy link
Member

@nuno-vieira nuno-vieira commented Jun 20, 2023 •
edited

馃敆 Issue Links

#2629

馃幆 Goal

Expose the Extra Data field in the Giphy Attachment Payload.

馃И Manual Testing Notes

N/A for manual QA.

Unit Tests where added to proof it works.

鈽戯笍 Contributor Checklist

  • I have signed the Stream CLA (required)
  • This change follows zero 鈿狅笍 policy (required)
  • This change should be manually QAed
  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Comparison screenshots added for visual changes
  • Affected documentation updated (docusaurus, tutorial, CMS)

@nuno-vieira nuno-vieira added the 馃寪聽SDK: StreamChat (LLC) Tasks related to the StreamChat LLC SDK label Jun 20, 2023
@nuno-vieira nuno-vieira requested a review from a team as a code owner June 20, 2023 17:35
@sonarcloud
Copy link

sonarcloud bot commented Jun 20, 2023

Kudos, SonarCloud Quality Gate passed!聽 聽 Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@nuno-vieira nuno-vieira merged commit b28e72f into develop Jun 21, 2023
17 checks passed
@nuno-vieira nuno-vieira deleted the add/expose-extra-data-on-giphy-attachment-payload branch June 21, 2023 11:10
@nuno-vieira nuno-vieira mentioned this pull request Jul 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@polqf polqf polqf approved these changes

Assignees
No one assigned
Labels
馃寪聽SDK: StreamChat (LLC) Tasks related to the StreamChat LLC SDK
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nuno-vieira @polqf