Fix custom ImageLoading
functions with default arguments not being called
#2695
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Issue Links
#2692
📝 Summary
When providing a custom
ImageLoading
implementation, some of the functions were not being called. This is because the default implementations provided through the extension in the protocol were using default arguments in the declaration, and this makes Swift think that it is a different function. So the solution is to provide additional declarations without the arguments, which can have default values.🧪 Manual Testing Notes
N/A for manual QA. Unit Tests were added to proof it works.
☑️ Contributor Checklist