Fix infinite loop when URLSessionWebSocketTask fails
#273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b-onc
approved these changes
May 14, 2020
buh
approved these changes
May 14, 2020
b-onc
reviewed
May 14, 2020
|
How come Danger didn't report on missing changelog? |
|
@VojtaStavik Danger doesn't run when a unit test fails. The test |
VojtaStavik
force-pushed
the
fix-loop
branch
3 times, most recently
from
f9cd2e5
to
242d03d
Compare
We do not want to call `doRead` again when the connection fails.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR:
The original implementation didn't behave correctly when the WS connection fails and ended up in the infinite loop and crashed.
We do not want to call
doRead()again when the connection fails.