Improve test stability #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b-onc
reviewed
May 14, 2020
SilentMessageTests were accessing shared client implicitly, now they do explicitly. It's not safe to use non-singleton client. QueryEncodingTests are now deterministic.
VojtaStavik
commented
May 15, 2020
Comment on lines
+24
to
+25
| func AssertJSONEqual(_ expression1: @autoclosure () throws -> Data, | ||
| _ expression2: @autoclosure () throws -> Data, |
There was a problem hiding this comment.
I wasn't sure about the expressions returning Data but we will probably create a number of convenient overrides for this as we will use it more. All good 👍
Comment on lines
+13
to
+15
| func error(domain: String, code: Int = -1, message: @autoclosure () -> String) -> NSError { | ||
| NSError(domain: domain, code: code, userInfo: ["message:": message()]) | ||
| } |
There was a problem hiding this comment.
I'd suggest making this private so we don't pollute the module namespace.
There was a problem hiding this comment.
I'm also using it in QueryEncodingTests though. Should i move it into its own file?
There was a problem hiding this comment.
I see. I think it's OK as is then.
|
I need one ✅ to be able to merge this :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR:
RequestRecorderURLProtocolrecord only selected requests if needed#no_changelog