[Background Mapping] Avoid crash when accessing DTOs while DB is being recreated #2934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
polqf
changed the title
polqf
force-pushed
the
bugfix/bg-mapping-map-deleted-item
branch
from
6e81f13
to
787102d
Compare
|
nuno-vieira
added a commit
that referenced
this pull request
Dec 13, 2023
…g recreated (#2934) * Make sure the object is valid before mapping it * Keep track of DB being deleted on BackgroundDatabaseObserver * Improve API to track if database is being removed --------- Co-authored-by: Pol Quintana <pol.quintana1@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Issue Links
https://github.com/GetStream/ios-issues-tracking/issues/625
🎯 Goal
Avoid crash when accessing DTOs from BackgroundDatabaseObserver while DB is being recreated
📝 Summary
There can be cases in which, because of the async nature of BackgroundDatabaseObserver, we can access a DTO that is no longer part of the DB if this one is being recreated. This can be reproduced in some cases when logging in and out pretty fast multiple times.
🛠 Implementation
This PR adds a thread guarded property (isDeletingDatabase) to BackgroundDatabaseObserver which will block any access to DTOs while the DB is being recreated.
🧪 Manual Testing Notes
Log in and out pretty fast multiple times
Expected result:
No crashes
☑️ Contributor Checklist
🎁 Meme