[CIS-265] Lazy model transformation for LLC #776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ManWithBear
added
the
🌐 SDK: StreamChat (LLC)
ManWithBear
commented
Jan 29, 2021
Sources/StreamChat/Controllers/ChannelController/LazyChannelController.swift
Outdated
Show resolved
Hide resolved
ManWithBear
commented
Jan 29, 2021
| .loadReplies(for: dto.id, limit: 25, context: context) | ||
| .map(_ChatMessage.init) | ||
|
|
||
| if dto.replies.isEmpty { |
There was a problem hiding this comment.
Don;t do DB queries, when here no need. It's super expensive.
Codecov Report
@@ Coverage Diff @@
## main #776 +/- ##
==========================================
- Coverage 89.13% 88.65% -0.48%
==========================================
Files 218 219 +1
Lines 8533 8570 +37
==========================================
- Hits 7606 7598 -8
- Misses 927 972 +45
Continue to review full report at Codecov.
|
ManWithBear
force-pushed
the
CIS-256-lazy-data
branch
2 times, most recently
from
434a27a
to
070a974
Compare
ManWithBear
changed the title
VojtaStavik
suggested changes
Feb 2, 2021
Sources/StreamChat/Controllers/ChannelController/ChannelController+SwiftUI.swift
Outdated
Show resolved
Hide resolved
Sources/StreamChat/Controllers/ChannelController/ChannelController+SwiftUI_Tests.swift
Outdated
Show resolved
Hide resolved
ManWithBear
force-pushed
the
CIS-256-lazy-data
branch
from
070a974
to
0397fb4
Compare
ManWithBear
commented
Feb 2, 2021
VojtaStavik
force-pushed
the
CIS-256-lazy-data
branch
from
be22de0
to
93ad632
Compare
|
@b-onc Since Denis has a day off today, I finished the PR. Can you please review it? |
VojtaStavik
force-pushed
the
CIS-256-lazy-data
branch
from
ff4b334
to
9846d96
Compare
VojtaStavik
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve performance of CoreData observers by introducing
LazyCachedMapCollection, data structure that applies transformations to underlying sequence on read access.Decrease amount of DB queries on DTO -> Model transformation when possible.
Huge FPS drop on channel open happens not because of message list layout or message load (affects it, but not critical).
Apparently when we open channel, channel list observer overload CPU by making useless job.