[CIS-586] Fix issue with decoding missing member_count in ChannelDetailPayload
#782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mantergo
added
the
🌐 SDK: StreamChat (LLC)
VojtaStavik
approved these changes
Jan 29, 2021
There was a problem hiding this comment.
Thanks @mantergo! Did you also check other fields based on https://github.com/GetStream/chat/blob/787a60b8521428d73fe819555b9996e16ef46201/types/channel.go#L374 ?
nuno-vieira
approved these changes
Jan 29, 2021
Codecov Report
@@ Coverage Diff @@
## main #782 +/- ##
=======================================
Coverage 88.63% 88.63%
=======================================
Files 218 218
Lines 8533 8533
=======================================
Hits 7563 7563
Misses 970 970
Continue to review full report at Codecov.
|
mantergo
force-pushed
the
CIS-586-fix-member-count-decoding
branch
from
1873093
to
73339b3
Compare
VojtaStavik
approved these changes
Jan 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR:
member_countinChannelDetailPayload