[CIS-632] Fix race conditions on database observers #796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VojtaStavik
added
the
🌐 SDK: StreamChat (LLC)
VojtaStavik
force-pushed
the
cis-632-fix-crash-in-current-user-controller
branch
from
4cbce9a
to
42d3fbc
Compare
b-onc
reviewed
Feb 3, 2021
| _item.computeValue = { [weak self] in | ||
| // Ideally, this should rather be `unowned`, however, `deinit` is not always called on the same thread as this | ||
| // callback which can cause a race condition when the object is already being deinited on a different thread. | ||
| guard let self = self else { return nil } |
There was a problem hiding this comment.
We don't need [weak self] here, we can get by with [weak frc] and the guard let fetchedObjects = frc?.fetchedObjects will take care of it
b-onc
approved these changes
Feb 3, 2021
cardoso
approved these changes
Feb 3, 2021
Codecov Report
@@ Coverage Diff @@
## main #796 +/- ##
==========================================
+ Coverage 88.62% 88.66% +0.04%
==========================================
Files 219 219
Lines 8570 8576 +6
==========================================
+ Hits 7595 7604 +9
+ Misses 975 972 -3
Continue to review full report at Codecov.
|
We already have a fix like this on other places in the observers. I just extended it to cover the other exposed cases, too.
VojtaStavik
force-pushed
the
cis-632-fix-crash-in-current-user-controller
branch
from
320a228
to
a6341fb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already have a fix like this at other places in the observers. I just extended it to cover the other exposed cases, too.
Fixed exactly as @cardoso suggested