[CIS-656] Revert changeHash changes #813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ManWithBear
added
the
🌐 SDK: StreamChat (LLC)
ManWithBear
force-pushed
the
no_more_hash
branch
from
b2a57f0
to
6f3d010
Compare
Generated by 🚫 Danger |
Codecov Report
@@ Coverage Diff @@
## main #813 +/- ##
==========================================
- Coverage 87.53% 86.76% -0.78%
==========================================
Files 229 228 -1
Lines 8812 8629 -183
==========================================
- Hits 7714 7487 -227
- Misses 1098 1142 +44
Continue to review full report at Codecov.
|
VojtaStavik
approved these changes
Feb 12, 2021
Comment on lines
+151
to
+156
|
|
||
| // Act: Save payload again | ||
| let user = try database.viewContext.saveUser(payload: payload) | ||
|
|
||
| // Assert: DTO should not contain any changes | ||
| XCTAssertFalse(user.hasPersistentChangedValues) |
There was a problem hiding this comment.
I like how we have almost 1k tests written in a certain way and you went "YOLO I'll do Arrange / Act / Assert" 😅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#802 made #752 changes obsolete. To keep codebase clean, we revert this changes, keeping new tests.