Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Django 1.11 compatibility issue: https://docs.djangoproject.com/e… #61

Closed
wants to merge 1 commit into from

Conversation

okrutny
Copy link

@okrutny okrutny commented Apr 29, 2017

…n/1.11/releases/1.11/#django-template-backends-django-template-render-prohibits-non-dict-context

  1. django.get_version() returns string, so it has to be parsed to float to be able to compare to 1.11
  2. Due to changes in Django 1.11: https://docs.djangoproject.com/en/1.11/releases/1.11/#django-template-backends-django-template-render-prohibits-non-dict-context, RequestContext, which comes to this templatetag has to be "reverted back" to context of type dict in order to be able to render it again.

@okrutny okrutny mentioned this pull request Apr 30, 2017
@tbarbugli
Copy link
Member

version numbers are not necessarily valid floats (eg. 1.6.11 is not)

@tbarbugli tbarbugli mentioned this pull request May 1, 2017
@tbarbugli
Copy link
Member

@okrutny we'll fix this and release a new version of stream-django tomorrow, thank you for your PR ;)

@tbarbugli tbarbugli closed this May 1, 2017
JelteF added a commit that referenced this pull request May 2, 2017
tbarbugli added a commit that referenced this pull request May 2, 2017
Cleaned up fix for django 1.11 (based on #61)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants