Do not break backwards compatibility for followMany method

GetStream · Jan 13, 2016 · 65f09b4 · 65f09b4
1 parent 2ec714d
commit 65f09b4
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 5 deletions.
diff --git a/src/lib/batch_operations.js b/src/lib/batch_operations.js
@@ -24,7 +24,7 @@ module.exports = {
     }, callback);
   },
 
-  followMany: function(follows, activityCopyLimit, callback)  {
+  followMany: function(follows, callbackOrActivityCopyLimit, callback)  {
     /**
      * Follow multiple feeds with one API call
      * @method followMany
@@ -35,10 +35,14 @@ module.exports = {
      * @param  {requestCallback} [callback] Callback called on completion
      * @return {Promise}           Promise object
      */
-    var qs = {};
+    var activityCopyLimit, qs = {};
 
-    if (activityCopyLimit && typeof activityCopyLimit !== 'number') {
-      throw new TypeError('Activity copy limit should be a number');
+    if (callbackOrActivityCopyLimit && typeof callbackOrActivityCopyLimit === 'number') {
+      activityCopyLimit = callbackOrActivityCopyLimit;
+    }
+
+    if (callbackOrActivityCopyLimit && typeof callbackOrActivityCopyLimit === 'function') {
+      callback = callbackOrActivityCopyLimit;
     }
 
     if (activityCopyLimit) {

diff --git a/test/unit/index.js b/test/unit/index.js
@@ -174,7 +174,7 @@ describe('Stream Client', function() {
       .reply(201, {"duration":"13ms"}, { });
 
     it('#followMany', function(done) {
-      client.followMany(follows, null, function(error, response, body) {
+      client.followMany(follows, function(error, response, body) {
         expect(error).to.be(null);
         done();
       });