Typescript #356
Merged
Typescript #356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +2.02 kB (2%) Total Size: 100 kB
|
bump dependencies
ferhatelmas
reviewed
Aug 11, 2020
ferhatelmas
reviewed
Aug 11, 2020
ferhatelmas
reviewed
Aug 11, 2020
| import utils from './utils'; | ||
| import signing from './signing'; | ||
|
|
||
| export default function createRedirectUrl(targetUrl, userId, events) { | ||
| // TODO: userId is skipped here |
There was a problem hiding this comment.
nice catch: if user_id is given we need to add it to token instead of *
ferhatelmas
reviewed
Aug 11, 2020
| } catch (e) { | ||
| return undefined; | ||
| } | ||
| } | ||
|
|
||
| function padString(string) { | ||
| function padString(string: string) { |
There was a problem hiding this comment.
let's rename it, looks awkward
ferhatelmas
reviewed
Aug 11, 2020
| if (contentType != null) fileField.type = contentType; | ||
| } | ||
|
|
||
| data.append('file', fileField); | ||
| return data; | ||
| } | ||
|
|
||
| function replaceStreamObjects(obj) { | ||
| // TODO: refactor and add proper types |
ferhatelmas
approved these changes
Aug 11, 2020
ferhatelmas
reviewed
Aug 11, 2020
| "homepage": "https://getstream.io/docs/?language=js", | ||
| "email": "support@getstream.io", | ||
| "license": "BSD-3-Clause", | ||
| "version": "5.0.5", | ||
| "version": "5.1.0-0", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.