Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove default exports #366

Merged
merged 5 commits into from
Aug 11, 2020
Merged

Remove default exports #366

merged 5 commits into from
Aug 11, 2020

Conversation

mahboubii
Copy link
Contributor

BREAKING CHANGES:

  • default export import stream from 'getstream' or const stream = require('getstream').default is removed
  • connect export is removed: import { connect } from 'getstream' or const {connect} = require('getstream')
  • Client export is removed and renamed to StreamClient: import { StreamClient } from 'getstream'
  • Signing export is removed: : import { JWTUserSessionToken, JWTScopeToken } from 'getstream'
  • errors export is removed: import { FeedError, SiteError, StreamApiError } from 'getstream'

@github-actions
Copy link
Contributor

github-actions bot commented Aug 11, 2020

Size Change: +473 B (0%)

Total Size: 101 kB

Filename Size Change
dist/js_min/getstream.js 31.3 kB +179 B (0%)
dist/js/getstream.js 69.5 kB +294 B (0%)

compressed-size-action

@mahboubii mahboubii changed the base branch from feature/typescript to master August 11, 2020 16:22
Copy link
Contributor

@ferhatelmas ferhatelmas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mahboubii mahboubii merged commit 38cd579 into master Aug 11, 2020
@mahboubii mahboubii deleted the remove-default-exports branch August 11, 2020 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants