Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #442: generalize foreignId type #450

Merged
merged 2 commits into from
May 5, 2021
Merged

Fix #442: generalize foreignId type #450

merged 2 commits into from
May 5, 2021

Conversation

mahboubii
Copy link
Contributor

@mahboubii mahboubii commented May 5, 2021 •
edited
Loading

Fix #442

@github-actions
Copy link
Contributor

github-actions bot commented May 5, 2021

Size Change: +46 B (0%)

Total Size: 95.5 kB

Filename Size Change
dist/js_min/getstream.js 29.7 kB +8 B (0%)
dist/js/getstream.js 65.8 kB +38 B (0%)

compressed-size-action

@mahboubii mahboubii changed the title Fix 442: generalize foreignId type Fix #442: generalize foreignId type May 5, 2021
@mahboubii mahboubii mentioned this pull request May 5, 2021
Closed
ferhatelmas
ferhatelmas approved these changes May 5, 2021
View reviewed changes
Copy link
Contributor

@ferhatelmas ferhatelmas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

It makes SDK more complex but usage is easier 👍🏻

@mahboubii mahboubii merged commit 6837e23 into main May 5, 2021
@delete-merged-branch delete-merged-branch bot deleted the standardize-foreign-id-type branch May 5, 2021 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ferhatelmas ferhatelmas ferhatelmas approved these changes

@arnautov-anton arnautov-anton Awaiting requested review from arnautov-anton arnautov-anton is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Why are there 3 alternately formatted names for foreign id in the node sdk?
2 participants
@mahboubii @ferhatelmas