Added createRedirectUrl to client and fixed timestamp issue on JWT's #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That's a good point, very slick implementation. |
| @@ -50,6 +53,7 @@ StreamClient.prototype = { | |||
| this.group = this.options.group || 'unspecified'; | |||
| // track subscriptions made on feeds created by this client | |||
| this.subscriptions = {}; | |||
| this.noJWTTimestamp = this.options.noJWTTimestamp || true; | |||
There was a problem hiding this comment.
hard to set noJWTTimestamp to false here ;)
There was a problem hiding this comment.
I would rename noJWTTimestamp (keep JWT out of it) to something like expireTokens or something similar.
|
Good catch, fixed the issue and renamed to expireTokens. |
tbarbugli
added a commit
that referenced
this pull request
Oct 28, 2015
Added createRedirectUrl to client and fixed timestamp issue on JWT's
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#61 and #58 both fixed. Used 'qs' library to create querystring. createRedirectUrl fails on incorrect targetUrl (similar to python implementation. Created two tests to test createRedirectUrl one to check whether wrong target urls result in an error and one to test the result. Notice that I decode the resulting JWT and check that result, instead of checking against an encoded JWT (like the python lib does). That is a bad idea because the order of the payload json affects the encoded JWT making the test really prone to failures (that do not origin from anything actually breaking) especially since dicts do not have a true ordering. Maybe a good idea to change this test in the py lib as well.