Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FVS-84: fix duplicate participant, dateTime parsing, reset StreamVideo on unregister #491

Merged
merged 1 commit into from
Sep 26, 2023
Merged

FVS-84: fix duplicate participant, dateTime parsing, reset StreamVideo on unregister #491

merged 1 commit into from
Sep 26, 2023

Conversation

kanat
Copy link
Contributor

@kanat kanat commented Sep 26, 2023

🎯 Goal

Fix several issues

  • duplicate participant
  • dateTime parsing
  • reset StreamVideo on unregister

☑️Contributor Checklist

General

  • Assigned a person / code owner group (required)
  • Thread with the PR link started in a respective Slack channel (#flutter-team) (required)
  • PR is linked to the GitHub issue it resolves

☑️Reviewer Checklist

  • Sample runs & works
  • UI Changes correct (before & after images)
  • Bugs validated (bugfixes)
  • New feature tested and works
  • All code we touched has new or updated Documentation

@kanat kanat marked this pull request as ready for review September 26, 2023 16:43
@kanat kanat requested a review from a team as a code owner September 26, 2023 16:43
@kanat kanat merged commit 6d543d0 into main Sep 26, 2023
3 of 5 checks passed
@kanat kanat deleted the fix/sdk-dogfooding branch September 26, 2023 17:05
@xsahil03x xsahil03x mentioned this pull request Sep 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xsahil03x xsahil03x xsahil03x approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kanat @xsahil03x