Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not join active call #499

Merged
merged 1 commit into from
Oct 6, 2023
Merged

Do not join active call #499

merged 1 commit into from
Oct 6, 2023

Conversation

kanat
Copy link
Contributor

@kanat kanat commented Oct 6, 2023

馃幆 Goal

Related thread:
https://getstream.slack.com/archives/C04EZ12CNLE/p1695984097377889

鈽戯笍Contributor Checklist

General

  • Assigned a person / code owner group (required)
  • Thread with the PR link started in a respective Slack channel (#flutter-team) (required)
  • PR is linked to the GitHub issue it resolves

鈽戯笍Reviewer Checklist

  • Sample runs & works
  • UI Changes correct (before & after images)
  • Bugs validated (bugfixes)
  • New feature tested and works
  • All code we touched has new or updated Documentation

@kanat kanat marked this pull request as ready for review October 6, 2023 23:38
@kanat kanat requested a review from a team as a code owner October 6, 2023 23:38
Nash0x7E2
Nash0x7E2 approved these changes Oct 6, 2023
View reviewed changes
Copy link
Member

@Nash0x7E2 Nash0x7E2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Nash0x7E2 Nash0x7E2 requested a review from Brazol October 6, 2023 23:56
@Nash0x7E2 Nash0x7E2 assigned Nash0x7E2 and kanat and unassigned Nash0x7E2 Oct 6, 2023
@Nash0x7E2 Nash0x7E2 merged commit fd2dffb into main Oct 6, 2023
3 of 5 checks passed
@Nash0x7E2 Nash0x7E2 deleted the fix/do-not-join-active-call branch October 6, 2023 23:56
kanat added a commit that referenced this pull request Oct 12, 2023
@kanat
fix typo from #499
3b717b7
@kanat kanat mentioned this pull request Oct 12, 2023
Merged
8 tasks
kanat added a commit that referenced this pull request Oct 12, 2023
@kanat
fix typo from #499
421c32a
kanat added a commit that referenced this pull request Oct 12, 2023
@kanat
fix typo from #499 (#501)
d13a2b5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nash0x7E2 Nash0x7E2 Nash0x7E2 approved these changes

@Brazol Brazol Awaiting requested review from Brazol

Assignees

@kanat kanat

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kanat @Nash0x7E2