Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: align with the latest openapi #1343

Merged
merged 12 commits into from
May 21, 2024
Merged

fix: align with the latest openapi #1343

merged 12 commits into from
May 21, 2024

Conversation

myandrienko
Copy link
Contributor

@myandrienko myandrienko commented May 8, 2024 •
edited
Loading

We have diverged from the latest OpenAPI spec quite a bit, so with 1.0 released seemed like a good time to align our types.

The update itself was pretty painless, except for a couple of renamings and fixes. However two places require attention, see comment below.

@myandrienko myandrienko marked this pull request as ready for review May 8, 2024 15:04
oliverlaz
oliverlaz reviewed May 8, 2024
View reviewed changes
Copy link
Member

@oliverlaz oliverlaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@szuperaz it would be good if you check this one as well. I think there is an overlap with #1316

packages/client/src/rtc/videoLayers.ts Outdated Show resolved Hide resolved
packages/client/src/gen/coordinator/index.ts Show resolved Hide resolved
@szuperaz szuperaz mentioned this pull request May 9, 2024
Closed
@szuperaz
Copy link
Contributor

szuperaz commented May 9, 2024

@szuperaz it would be good if you check this one as well. I think there is an overlap with #1316

Looks good to me, I closed the old PR in favor of this.

@myandrienko myandrienko mentioned this pull request May 16, 2024
Closed
@myandrienko myandrienko changed the title feat: align with the latest openapi fix: align with the latest openapi May 21, 2024
@myandrienko myandrienko merged commit 2cb71cc into main May 21, 2024
22 checks passed
@myandrienko myandrienko deleted the feat/openapi-alignment branch May 21, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliverlaz oliverlaz oliverlaz approved these changes

@szuperaz szuperaz szuperaz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@myandrienko @szuperaz @oliverlaz