fix: improve error handling across the SDK #1350
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Improves how unhandled promise rejections and unhandled observable errors are handled across the SDK.
We used to ignore promise rejections in the PeerConnection event handlers. This lead to situations where tools like Sentry were reporting too many incidents due to this. Now, the SDK gracefully handles these errors.
In the device management part, the
.listDevices()
method throws an error when the user rejects the prompted browser permissions. Now, instead of erroring, we return an empty list.