Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve error handling across the SDK #1350

Merged
merged 1 commit into from
May 13, 2024
Merged

fix: improve error handling across the SDK #1350

merged 1 commit into from
May 13, 2024

Conversation

oliverlaz
Copy link
Member

Overview

Improves how unhandled promise rejections and unhandled observable errors are handled across the SDK.

We used to ignore promise rejections in the PeerConnection event handlers. This lead to situations where tools like Sentry were reporting too many incidents due to this. Now, the SDK gracefully handles these errors.

In the device management part, the .listDevices() method throws an error when the user rejects the prompted browser permissions. Now, instead of erroring, we return an empty list.

@oliverlaz oliverlaz merged commit ac0ae3b into main May 13, 2024
20 of 21 checks passed
@oliverlaz oliverlaz deleted the err-handling branch May 13, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants