fix: prevent double sound detectors set up #1371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliverlaz
approved these changes
May 24, 2024
myandrienko
added a commit
that referenced
this pull request
Jun 12, 2024
Adds three concurrency helpers: 1. `withoutConcurrency` - accepts async functions and makes sure they run one after another, and never in parallel. 2. `withCancelation` - does the same thing, but also cancels all other async functions when a new function is scheduled. Useful for actions that override each other, like enabling and disabling camera. 3. `createSafeAsyncSubscription` adds an async listener to an Rx observable, and makes sure listeners never run in parallel, even if updates come in quicker than handlers can run. As an example, those utilities are adopted in two places, where ad-hoc solutions were previously added: #1371 #1342
myandrienko
added a commit
that referenced
this pull request
Jun 12, 2024
Adds three concurrency helpers: 1. `withoutConcurrency` - accepts async functions and makes sure they run one after another, and never in parallel. 2. `withCancelation` - does the same thing, but also cancels all other async functions when a new function is scheduled. Useful for actions that override each other, like enabling and disabling camera. 3. `createSafeAsyncSubscription` adds an async listener to an Rx observable, and makes sure listeners never run in parallel, even if updates come in quicker than handlers can run. As an example, those utilities are adopted in two places, where ad-hoc solutions were previously added: #1371 #1342
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling
startSpeakingWhileMutedDetectionmultiple types without awaiting leads to multiple sound detectors being set up. CallingstopSpeakingWhileMutedDetectionafterwords cleans up only one of them.Since
startSpeakingWhileMutedDetectionis called in a callback to an Rx observable, it's very possible that multiple sound detectors will be set up when the state updates fire rapidly.This fix prevents that.