feat(react-native): add livestream player component #1373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khushal87
reviewed
May 27, 2024
| if (!call) { | ||
| return; | ||
| } | ||
| call.join().catch((e) => { |
There was a problem hiding this comment.
Can we have try catch instead of .then.catch?
There was a problem hiding this comment.
my opinion is that it doesnt matter here. Both are fine.
When we chain promises I would rather go for try/catch, for single promise, just having catch is fine in a useEffect scenario
khushal87
reviewed
May 27, 2024
| console.error('Failed to join call', e); | ||
| }); | ||
| return () => { | ||
| call.leave().catch((e) => { |
khushal87
approved these changes
May 27, 2024
oliverlaz
added a commit
that referenced
this pull request
May 27, 2024
Adds the missing component export for the `LivestreamPlayer` component. #1373
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.