fix(react): provide displayName for our core components #1423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliverlaz
requested review from
myandrienko,
szuperaz,
MartinCupela and
arnautov-anton
myandrienko
approved these changes
Jun 26, 2024
oliverlaz
commented
Jun 26, 2024
Comment on lines
+8
to
+12
| export const StreamCall: ComponentType< | ||
| PropsWithChildren<StreamCallProviderProps> | ||
| > = StreamCallProvider; | ||
|
|
||
| StreamCall.displayName = 'StreamCall'; |
There was a problem hiding this comment.
I have mixed feelings about whether this should go to react-bindings or not. Any thoughts?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Adds
.displayNameproperty to our core SDK components.This should make it easier to debug our SDK in production/minified environments.
Context: https://getstream.slack.com/archives/C06CF5TKRGA/p1719396728909279