Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed
The main change in this PR is in MyProfile. Previously it was requiring a
contentView
to be passed in which would contain the bulk of the profile UI, which was mostly defined inMyProfileInfoAndTweets
. After seeing if I could swap the two, it became apparent why it may have been done this way since MyProfileInfoAndTweets relies on feed information and lives in theTimelineUI
micro framework. Trying to simply move MyProfileInfoAndTweets into the Profile framework would not work because it would create a circular dependency.What I was able to do instead was extract the bulk of the profile UI back into MyProfile and then optionally provide additional content that would still exist in the scrollview on my profile. That way
MyProfileInfoAndTweets
can call MyProfile and provide theForYouFeedsView
as its footer content as intended.Other changes
EditProfileView
removing unused variables and some minor label changes.ProfileInfoViewModel
that help making the code in the view easier to readSettingsView
to initially populate with the current logged in user, as well as extracted out each row/view for readabilityHow to test