Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Show Redirects added) gatget do not load all redirects at the begining #19

Merged
merged 1 commit into from
Nov 15, 2016
Merged

(Show Redirects added) gatget do not load all redirects at the begining #19

merged 1 commit into from
Nov 15, 2016

Conversation

hypknot
Copy link
Contributor

@hypknot hypknot commented Nov 15, 2016

In visma.com page we are using this plugin for our custom redirects.
The issue we have with this tool is that we have a lot of custom redirects and way too much suggestions in our environment (10 million+). in this case when we open dashboard the gatget loads for ages and it takes a lot of resources of our environment. Also when "Dashboard" is opened by multiple editors it makes our environment quite slow while everything is loading.

In this case we decided to upgrade this gatget with one extra button "Show redirects".

When you open "Dashboard" the gatget firstly not try to show all redirects, but shows an empty list. in this case environment don't have heavy work to do. and if the user wants to see all redirects he just simply clicks "Show redirects" checkbox and at this point gatget will show all redirects. All other functionality is not changed, everything else is working as it should work.

Pros of this feature:

  1. Gatget don't load all redirects unless you chose it.
  2. Reduce load of environment when you open "Dashboard".

Cons of this feature:

  1. One extra checkbox near the search input.

@evest
Copy link
Contributor

evest commented Nov 15, 2016

I understand the problem, and think this is a reasonable request. We have started a change that will put the redirects in a separate database table to make it a lot faster for large amounts of redirects. This should effectively render this PR unnecessary. However, I'm tempted to merge this in for now, since I don't know when the new version will be done.

You have removed the nuget.org reference, so it does not build :-) I'll fix that.

Btw. you should really remove some of the suggestions, you can safely delete from that table, like everything older than half a year or so depending on how much history you'd like.

@evest evest merged commit 908168a into Geta:master Nov 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants