Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FontAwesome 5.6.1, fix XML docs, unit tests & concurrency bug fix. #8

Merged
merged 3 commits into from Jan 7, 2019

Conversation

johanbenschop
Copy link
Contributor

Merry Christmas! The primary change in this pull request is the update of FontAwesome to version 5.6.1.

Also:

  • Improved the generator which now directly pulls from GitHub and updates the files in one fell swoop (given FontAweomse doesn't change their folder structure).
  • Now including the DocumentationFile inside the NuGet package so consumers get the documentation of the enums.
  • Improved the unit tests to use XUnits MemerData functionality to generate tests per value in an enum.
  • Two types of tests, one for embedded and one for custom fonts. Total 4308 tests ~50 seconds to run them.
  • Tests now count the unique colors per image to verify the icon could be found.
  • The tests give a code coverage of 55.73%.
  • While making these tests I got random exceptions with something about an error in GDI+ when running tests in parallel with multiple font styles. Solved this by adding a MemoryCache to the LoadFontFamily methods in the FontThumbnailService.
  • While debugging I also improved the code, like adding in more using statements for disposing of objects.

I look forward to feedback (if any).

Copy link
Collaborator

@degborta degborta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merry christmas @johanbenschop and thanks for the contribution. It looks really nice! Only stumbled on one version conflict that I added a suggestion for. Take a look and get back with your comments.

@degborta degborta merged commit 26a064c into Geta:master Jan 7, 2019
@johanbenschop johanbenschop deleted the feature/fa-5.6 branch January 7, 2019 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants